Re: [PATCH 2/2] arm64: dts: rockchip: Add Orange Pi 5 Pro board support

[Jimmy Hon]

Hi Dennis,

Some curiosities below,

On Sat, Feb 28, 2026 at 2:54 PM <dennis@xxxxxxxx> wrote:
<snip>
> +
> +       /* Pro uses gpio-leds instead; pwm0 LED is not wired up */
> +       /delete-node/ pwm-leds;
<snip>
> +
> +       gpio-leds {
> +               compatible = "gpio-leds";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&leds_rgb>;
> +
> +               blue-led {
> +                       color = <LED_COLOR_ID_BLUE>;
> +                       function = LED_FUNCTION_STATUS;
> +                       gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_HIGH>;
How come you decided gpio-leds instead of pwm-leds for this? GPIO1 C6
is muxed with PWM15_IR_M2
> +                       linux,default-trigger = "heartbeat";
> +               };
> +
> +               green-led {
> +                       color = <LED_COLOR_ID_GREEN>;
> +                       function = LED_FUNCTION_ACTIVITY;
> +                       gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
How come you decided gpio-leds instead of pwm-leds for this? GPIO1 C2
is muxed with PWM3_IR_M2.
> +                       linux,default-trigger = "mmc0";
> +               };
> +       };

Jimmy