Re: [PATCH v1 4/8] ACPI: x86/rtc-cmos: Use platform device for driver binding
From: Nathan Chancellor
Date: Tue Mar 03 2026 - 01:08:00 EST
Hi Rafael,
On Mon, Feb 23, 2026 at 04:30:21PM +0100, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
>
> Modify the rtc-cmos driver to bind to a platform device on systems with
> ACPI via acpi_match_table and advertise the CMOST RTC ACPI device IDs
> for driver auto-loading. Note that adding the requisite device IDs to
> it and exposing them via MODULE_DEVICE_TABLE() is sufficient for this
> purpose.
>
> Since the ACPI device IDs in question are the same as for the CMOS RTC
> ACPI scan handler, put them into a common header file and use the
> definition from there in both places.
>
> Additionally, to prevent a PNP device from being created for the CMOS
> RTC if a platform one is present already, make is_cmos_rtc_device()
> check cmos_rtc_platform_device_present introduced previously.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
After this change in -next as commit 2a78e4210444 ("ACPI: x86/rtc-cmos:
Use platform device for driver binding"), I am seeing
rtc_cmos PNP0B00:00: error -ENXIO: IRQ index 0 not found
on a few of my test machines. Is this expected?
Cheers,
Nathan
# bad: [d517cb8cea012f43b069617fc8179b45404f8018] Add linux-next specific files for 20260302
# good: [11439c4635edd669ae435eec308f4ab8a0804808] Linux 7.0-rc2
git bisect start 'd517cb8cea012f43b069617fc8179b45404f8018' '11439c4635edd669ae435eec308f4ab8a0804808'
# bad: [30cad5d4db9212a3e9bb99be1d99c4fbc17966c7] Merge branch 'master' of https://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next.git
git bisect bad 30cad5d4db9212a3e9bb99be1d99c4fbc17966c7
# good: [3d6642ce50abe4cccbbc4cfda0808300b4f39cb6] Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
git bisect good 3d6642ce50abe4cccbbc4cfda0808300b4f39cb6
# good: [e832bc0903e6b85f9f084fef0a9d51bbbbcc1ee7] Merge branch 'for-next/pstore' of https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git
git bisect good e832bc0903e6b85f9f084fef0a9d51bbbbcc1ee7
# bad: [ef26f99b113b16135282e2cda9ee8afda2d39e10] Merge branch 'for-next' of https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
git bisect bad ef26f99b113b16135282e2cda9ee8afda2d39e10
# good: [df57aa49ec08ebe55d2840e3950be37bff3a8853] Merge branch 'docs-next' of git://git.lwn.net/linux.git
git bisect good df57aa49ec08ebe55d2840e3950be37bff3a8853
# bad: [8aec61332e195aae38737a3b6454526938132f41] Merge branch 'next' of https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git
git bisect bad 8aec61332e195aae38737a3b6454526938132f41
# bad: [ea956cb5e17cb5910382be255aa2329e067edd3b] Merge branch 'cpupower' of https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git
git bisect bad ea956cb5e17cb5910382be255aa2329e067edd3b
# bad: [0953f6a5e08b6fc636b17e00dcac3d9eeef78e72] Merge branch 'acpi-cmos-rtc' into linux-next
git bisect bad 0953f6a5e08b6fc636b17e00dcac3d9eeef78e72
# bad: [0139085310c40853cc429d5c38fd66e540c97d34] x86: rtc: Drop PNP device check
git bisect bad 0139085310c40853cc429d5c38fd66e540c97d34
# good: [1ae2f435350ec05224a39995c3a680aa6fdae5a5] ACPI: x86: cmos_rtc: Create a CMOS RTC platform device
git bisect good 1ae2f435350ec05224a39995c3a680aa6fdae5a5
# bad: [d15f1c2e413e861270ca6aa5dc5d9da1bcd678ca] ACPI: PNP: Drop CMOS RTC PNP device support
git bisect bad d15f1c2e413e861270ca6aa5dc5d9da1bcd678ca
# bad: [2a78e42104444f948698f1225deaf515e9b7224d] ACPI: x86/rtc-cmos: Use platform device for driver binding
git bisect bad 2a78e42104444f948698f1225deaf515e9b7224d
# first bad commit: [2a78e42104444f948698f1225deaf515e9b7224d] ACPI: x86/rtc-cmos: Use platform device for driver binding