Re: [PATCH] pinctrl: core: use dev_err_probe() when applying state

[Linus Walleij]

On Sun, Mar 1, 2026 at 5:46 PM Michal Piekos
<michal.piekos@xxxxxxxxxxxxx> wrote:

> When applying a pinctrl state, -EPROBE_DEFER may be returned if
> dependencies are not ready and the consumer will retry probing.
>
> This is normal probe ordering behaviour and not a real error.
> However, pinctrl core currently logs:
>
>   "Error applying setting, reverse things back"
>
> even when the return value is -EPROBE_DEFER, resulting in noisy
> boot-time error messages.
>
> Replace dev_err() with dev_err_probe() to handle -EPROBE_DEFER
> consistently and suppress error logging for deferred probes.
>
> No functional change intended.
>
> Signed-off-by: Michal Piekos <michal.piekos@xxxxxxxxxxxxx>
> ---
> This series contains a single patch to suppress spurious
> boot-time error messages when applying pinctrl states during
> normal probe deferral.
>
> Currently, pinctrl core logs an error even when
> -EPROBE_DEFER is returned, which is expected probe-ordering
> behaviour.
>
> Switch to dev_err_probe() so deferred probes do not emit
> misleading error logs.

Patch applied.

Mysterious overly-verbose commit log have traces of AI
spice.

It is mandatory to mention in the commit message if an AI
tool was used to generate the patch, was it? In that
case tell me so I can augment the commit log.

Yours,
Linus Walleij