Re: [PATCH v1 1/1] serial: 8250_port: Drop duplicate NULL check

[Andy Shevchenko]

On Tue, Mar 03, 2026 at 06:25:29AM +0100, Jiri Slaby wrote:
> On 02. 03. 26, 16:27, Andy Shevchenko wrote:
> > serial8250_release_dma() is NULL-aware, no need to check this in the caller.
> > While at it, make sure DMA won't be used again, by NULLifying the pointer.

> >   	synchronize_irq(port->irq);
> > -	if (up->dma)
> > -		serial8250_release_dma(up);
> > +	serial8250_release_dma(up);
> > +	up->dma = NULL;
> 
> Shouldn't serial8250_release_dma() NULL it instead, so the callers need not
> to bother?

I copied what 8250_omap is doing. But we can do what you suggested I think.

-- 
With Best Regards,
Andy Shevchenko