Re: [PATCH v2 1/3] arm64: dts: qcom: monaco-evk: Enable GPIO expander interrupt for Monaco EVK

From: Konrad Dybcio

Date: Tue Mar 03 2026 - 05:00:03 EST


On 3/3/26 9:21 AM, Swati Agarwal wrote:
> Enable PCA9538 expander as interrupt controller on Monaco EVK and configure
> the corresponding TLMM pins via pinctrl to operate as GPIO inputs with
> internal pull-ups.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@xxxxxxxxxxxxxxxx>
> ---

[...]

> &tlmm {
>
> +
Stray \n above

expander0_int: expander0-int-state {
> + pins = "gpio56";

The TLMM entries are currently ordered by the pin index - please retain
that.

Otherwise, this looks good

Konrad