Re: [PATCH 1/2] arm64: lib: xor-neon: remove redundant filename comment
From: Catalin Marinas
Date: Tue Mar 03 2026 - 05:51:14 EST
On Mon, Mar 02, 2026 at 04:01:45PM +0000, Josh Law wrote:
> 2 Mar 2026 13:52:07 Christoph Hellwig <hch@xxxxxxxxxxxxx>:
> > On Sun, Mar 01, 2026 at 03:28:19PM +0000, Josh Law wrote:
> >> The filename in the header comment is redundant and not recommended
> >> by Linux kernel coding style.
> >
> > I have a pretty big series pending that changes this file in
> > meaninful ways. But even without that please never send standalone
> > patches for trivial cleanups like this, only do them if you have to
> > touch the code for another reason anyway.
>
> Hello Cristoph, I am sorry, again
> Since I am new to Linux kernel development
> I sometimes make mistakes, it's normal.
> Patch 2 should be more relevant, all of those I got under checkpatch.pl
Patch 2 is not relevant either. Unnecessary change that will make things
harder to backport, conflict with other changes.
Please don't run checkpatch.pl on existing code, only on new patches
before they are upstreamed.
--
Catalin