Re: [PATCH v3] dt-bindings: dma: xlnx,axi-dma: Convert to DT schema
From: Rob Herring (Arm)
Date: Tue Mar 03 2026 - 07:31:59 EST
On Tue, 03 Mar 2026 17:11:24 +0530, Abin Joseph wrote:
> Convert the bindings document for Xilinx DMA.
> No changes to existing binding description.
>
> Signed-off-by: Abin Joseph <abin.joseph@xxxxxxx>
> ---
>
> v3:
> -> Update the subject heading
> -> Remove examples for cdma and mcdma
> -> Fix the syntax issue for the clocks
> -> Squash the interrupt use case for axistream
> connected cases.
> -> Reorder the list as per the writing bindings
>
> v2:
> -> Add examples for each compatible
> -> Remove the note added
> -> Use 'enum' rather than 'anyOf' and 'const'
> -> Wrap 80 char per line for descriptions
> -> Add dma-controller yaml reference
> -> Add -| for paragraph separation
> ->Remove labels from the examples
>
> ---
> .../bindings/dma/xilinx/xilinx_dma.txt | 111 -------
> .../bindings/dma/xilinx/xlnx,axi-dma.yaml | 301 ++++++++++++++++++
> 2 files changed, 301 insertions(+), 111 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> create mode 100644 Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml: allOf:1:then:properties:clock-names: {'items': [{'const': 's_axi_lite_aclk'}, {'const': 'm_axi_mm2s_aclk'}, {'const': 'm_axi_s2mm_aclk'}, {'const': 'm_axis_mm2s_aclk'}, {'const': 's_axis_s2mm_aclk'}], 'minItems': 1, 'maxItems': 5} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/xilinx/xlnx,axi-dma.yaml: allOf:3:then:properties:clock-names: {'items': [{'const': 's_axi_lite_aclk'}, {'const': 'm_axi_mm2s_aclk'}, {'const': 'm_axi_s2mm_aclk'}, {'const': 'm_axi_sg_aclk'}], 'minItems': 1, 'maxItems': 4} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260303114125.899850-1-abin.joseph@xxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.