Re: [PATCH net-next 2/8] dt-bindings: net: lan9645x: add LAN9645X switch bindings

[Andrew Lunn]

> +        properties:
> +          microchip,led-drive-mode:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            description: |
> +              Set the LED drive mode for the copper PHY associated with
> +              this port.
> +
> +                0 - LED1 and LED2 in open-drain mode
> +                1 - LED1 in active drive mode (can be used for single-LED
> +                    configurations requiring active drive)
> +                2 - Reserved
> +                3 - LED1 and LED2 in active drive mode
> +            minimum: 0
> +            maximum: 3

I doubt the DT Maintainers will accept that. This looks a lot like a
value you write into a register. How are active drive and open-drain
described in other DT bindings? Is there something you can reuse?

For 1, what happens to LED2? Not used at all?

    Andrew