Re: [PATCH v2 0/3] Allow attaching software node when registering platform devices

From: Dmitry Torokhov

Date: Tue Mar 03 2026 - 11:02:07 EST


Hi Danilo,

On Mon, Mar 02, 2026 at 03:39:51PM +0100, Danilo Krummrich wrote:
> On Mon Mar 2, 2026 at 1:42 AM CET, Danilo Krummrich wrote:
> > On Sun Mar 1, 2026 at 6:02 AM CET, Dmitry Torokhov wrote:
> >>> Unless there there is any contrary feedback from Greg or Rafael, I can pick up
> >>> the series after -rc1 is out and hand out a signed tag for the two of those.
> >>
> >> Yes, could this be applied please? I have a few patches that depend on
> >> this that I'd like to send out.
> >
> > Sorry for the delay, will do tomorrow!
>
> Again, sorry for the delay, I gave this some extra cycles to make sure Greg and
> Rafael have a chance to comment (especially since this will be shared with other
> trees).
>
> I now applied this to driver-core-testing; I will share a signed tag once I have
> the 0day result.

Thank you!

>
> I have one consideration about the
>
> if (pdevinfo->swnode && pdevinfo->properties)
> return ERR_PTR(-EINVAL);
>
> case (which I hate we can't catch at compile time). Maybe it is worth to at
> least print a warning?

I am not sure how much it will help: the setup is typically static so
the developer using this change/api will immediately run into this error
if they try to set both, users will not see it.

OTOH it is a single message...

Thanks.

--
Dmitry