Re: [PATCH 1/2] hwmon: (ina2xx) clean up unused macro and outdated comment

[Guenter Roeck]

On Tue, Mar 03, 2026 at 12:07:01PM +0100, Jonas Rebmann wrote:
> The list of supported chips in the header is incomplete and contains no
> other information not readily available. Remove the list and instead
> hint that the chips supported by this driver have 219/226 compatible
> register layout [unlike the ones supported by e.g. ina238].
> 
> Remove the unused INA226_DIE_ID macro.

It is a define, not a macro. I'll change that in the commit message.

> 
> Signed-off-by: Jonas Rebmann <jre@xxxxxxxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ina2xx.c | 20 ++------------------
>  1 file changed, 2 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> index 836e15a5a780..6a2cebbb9f15 100644
> --- a/drivers/hwmon/ina2xx.c
> +++ b/drivers/hwmon/ina2xx.c
> @@ -1,22 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * Driver for Texas Instruments INA219, INA226 power monitor chips
> - *
> - * INA219:
> - * Zero Drift Bi-Directional Current/Power Monitor with I2C Interface
> - * Datasheet: https://www.ti.com/product/ina219
> - *
> - * INA220:
> - * Bi-Directional Current/Power Monitor with I2C Interface
> - * Datasheet: https://www.ti.com/product/ina220
> - *
> - * INA226:
> - * Bi-Directional Current/Power Monitor with I2C Interface
> - * Datasheet: https://www.ti.com/product/ina226
> - *
> - * INA230:
> - * Bi-directional Current/Power Monitor with I2C Interface
> - * Datasheet: https://www.ti.com/product/ina230
> + * Driver for Texas Instruments INA219, INA226 and register-layout compatible
> + * current/power monitor chips with I2C Interface
>   *
>   * Copyright (C) 2012 Lothar Felten <lothar.felten@xxxxxxxxx>
>   * Thanks to Jan Volkering
> @@ -49,7 +34,6 @@
>  /* INA226 register definitions */
>  #define INA226_MASK_ENABLE		0x06
>  #define INA226_ALERT_LIMIT		0x07
> -#define INA226_DIE_ID			0xFF
>  
>  /* SY24655 register definitions */
>  #define SY24655_EIN				0x0A