Re: [PATCH v2 1/7] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding

[Vikash Garodia]

On 2/28/2026 1:22 AM, Dmitry Baryshkov wrote:
> On Fri, Feb 27, 2026 at 07:41:17PM +0530, Vikash Garodia wrote:
> > Kaanapali SOC brings in the new generation of video IP i.e iris4. When
> > compared to previous generation, iris3x, it has,
> > - separate power domains for stream and pixel processing hardware blocks
> >    (bse and vpp).
> > - additional power domain for apv codec.
> > - power domains for individual pipes (VPPx).
> > - different clocks and reset lines.
> >
> > iommu-map include all the different stream-ids which can be possibly
> > generated by vpu4 hardware as below,
> > bitstream stream from vcodec
> > non-pixel stream from vcodec
> > non-pixel stream from tensilica
> > pixel stream from vcodec
> > secure bitstream stream from vcodec
> > secure non-pixel stream from vcodec
> > secure non-pixel stream from tensilica
> > secure pixel stream from vcodec
> > firmware stream from tensilica (might be handled by the TZ / hyp)
> >
> > This patch is depend on the below dt-schema patch.
> > Link: https://github.com/devicetree-org/dt-schema/pull/184/changes/d341298d62805bc972dfba691da6b3b62aa3ff15
> > Signed-off-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> > ---
> >   .../bindings/media/qcom,kaanapali-iris.yaml        | 261 +++++++++++++++++++++
> >   include/dt-bindings/media/qcom,iris.h              |  18 ++
> >   2 files changed, 279 insertions(+)
> >
> > +
> > +  iommu-map:
> > +    description: |
> > +        - bitstream stream from vcodec
> > +        - non-pixel stream from vcodec
> > +        - non-pixel stream from tensilica
> > +        - pixel stream from vcodec
> > +        - secure bitstream stream from vcodec
> > +        - secure non-pixel stream from vcodec
> > +        - secure non-pixel stream from tensilica
> > +        - secure pixel stream from vcodec
> > +        # firmware might be handled by the TZ / hyp
> > +        - firmware stream from tensilica
>
> Why are you providing description as a list rather than describing each
> item separately? Then you wouldn't need maxItems.

rewrote them as below and dropped maxItems. Please review.

iommu-map:
    $ref: /schemas/types.yaml#/definitions/uint32-matrix
    items:
      - description: bitstream stream from vcodec
        items:
          - description: Function ID
          - description: Phandle to IOMMU
          - description: IOMMU stream ID base
          - description: IOMMU stream ID mask
          - description: Number of stream IDs
      - description: non-pixel stream from vcodec
      - description: non-pixel stream from tensilica
      - description: pixel stream from vcodec
      - description: secure bitstream stream from vcodec
      - description: secure non-pixel stream from vcodec
      - description: secure non-pixel stream from tensilica
      - description: secure pixel stream from vcodec
      # firmware might be handled by the TZ / hyp
      - description: firmware stream from tensilica
    minItems: 8

> > +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > +    items:
> > +      $ref: '#/definitions/iommu-types'
> > +      minItems: 5
> > +    minItems: 8
> > +    maxItems: 9
> > +

Regards,
Vikash