Re: [PATCH net-next 1/4] dt-bindings: net: cdns,macb: add a compatible for Microchip p64h

[Conor Dooley]

On Tue, Mar 03, 2026 at 10:03:15AM -0800, Charles Perry wrote:
> "p64h" is shorthand for "PIC64-HPSC" and "PIC64HX"

No, sorry. If these are different SoCs they need to have SoC-specific
compatibles, particularly since PIC64HY could be something that is not
compatible with these devices. It'd be fine to add
"microchip,pic64hpsc-gem" with "microchip,pic64hx-gem" as a fallback
though, since they do appear to be very very very similar devices and
can clearly share the same match data in the driver. That's what pic64gx
and mpfs do.

pw-bot: changes-requested

Cheers,
Conor.

> 
> The generic compatible "cdns,gem" works but offers limited features.
> Keep it as a fallback.
> 
> Signed-off-by: Charles Perry <charles.perry@xxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index cb14c35ba996..dff350302098 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -27,6 +27,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - microchip,p64h-gem    # Microchip P64H SoC
>                - xlnx,versal-gem       # Xilinx Versal
>                - xlnx,zynq-gem         # Xilinx Zynq-7xxx SoC
>                - xlnx,zynqmp-gem       # Xilinx Zynq Ultrascale+ MPSoC
> -- 
> 2.47.3
>

Attachment: signature.asc
Description: PGP signature