Re: [PATCH net-next v2 1/4] bnxt_en: use bnxt_xdp_buff for xdp context

From: Joe Damato

Date: Tue Mar 03 2026 - 13:41:24 EST


On Mon, Mar 02, 2026 at 08:43:49PM -0600, Chris J Arges wrote:
> This adds bnxt_xdp_buff which embeds the xdp_buff struct and stores
> pointers to hardware RX completion descriptors (rx_cmp and rx_cmp_ext)
> along with the completion type.
>
> Signed-off-by: Chris J Arges <carges@xxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 +++++++++++--------
> drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 7 ++++++
> 2 files changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index c982aac714d1..ab73aad40593 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -2118,7 +2118,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
> bool xdp_active = false;
> dma_addr_t dma_addr;
> struct sk_buff *skb;
> - struct xdp_buff xdp;
> + struct bnxt_xdp_buff bnxt_xdp;

Not sure if it matters but similar RCT issue here.

Otherwise the rest of the implementation looks OK to me, you can retain my
Reviewed-by if you are respinning to fix a cosmetic thing:

Reviewed-by: Joe Damato <joe@xxxxxxx>