Re: [PATCH WIP v4 3/9] media: qcom: camss: Prepare CSID for C-PHY support
From: David Heidelberg
Date: Tue Mar 03 2026 - 15:32:05 EST
On 03/03/2026 10:53, Bryan O'Donoghue wrote:
On 01/03/2026 00:51, David Heidelberg via B4 Relay wrote:
+ bool cphy;
Same comment as before, you should have an enum not a bool.
While for general camss it makes sense to me, here it seems to be very simple switch with no other extra usefulness.
If u insist, I'll change it, but LGTM with cphy here.
David
---
bod
--
David Heidelberg