Re: [PATCH v1] arm64: dts: freescale: imx95-toradex-smarc: Support Cortex M7

[Frank Li]

From: Frank Li (AI-BOT) <frank.li@xxxxxxx>

AI bot review and may be useless.

---

> +	cm7: remoteproc-cm7 {
> +		compatible = "fsl,imx95-cm7";
> +		mbox-names = "tx", "rx", "rxdb";
> +		mboxes = <&mu7 0 1
> +			  &mu7 1 1
> +			  &mu7 3 1>;
> +		memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
> +				<&vdev1vring0>, <&vdev1vring1>, <&rsc_table>, <&m7_reserved>;
> +	};

Line 51 exceeds 80 columns; consider breaking memory-region into
multiple lines for readability.

---

> +	m7_reserved: memory@80000000 {
> +		reg = <0 0x80000000 0 0x1000000>;
> +		no-map;
> +	};

Consider adding a comment explaining the 16 MB reservation size and
purpose (firmware load address, etc.).

---

> +	rsc_table: memory@88220000 {
> +		reg = <0 0x88220000 0 0x1000>;
> +		no-map;
> +	};

Consider documenting why rsc_table is placed at this specific offset
relative to m7_reserved.

---

> +	vdevbuffer: memory@88020000 {
> +		compatible = "shared-dma-pool";
> +		reg = <0 0x88020000 0 0x100000>;
> +		no-map;
> +	};

Verify that the 1 MB vdevbuffer size is sufficient for the expected
virtio traffic between A55 and M7.

---

> +&mu7 {
> +	status = "okay";
> +};

Ensure mu7 node is defined elsewhere in the base device tree; this
patch only enables it without defining its properties.