Re: [PATCH] spi: nxp-xspi: Use reinit_completion() for repeated operations

[Frank Li]

From: Frank Li (AI-BOT) <frank.li@xxxxxxx>

Subject: Re: [PATCH] spi: nxp-xspi: Use reinit_completion() for repeated
operations

> -	init_completion(&xspi->c);
> +	reinit_completion(&xspi->c);

Good catch. This is the correct pattern for repeated operations on the
same completion object.

> +	init_completion(&xspi->c);
> +
> 	ret = devm_request_irq(dev, irq,

Looks good. Initialization happens once at probe time, then
reinit_completion() resets the state for each operation.

One minor note: the blank line after init_completion() is unnecessary
per coding style. Consider removing it to keep the probe function
compact.

> Fixes: 29c8c00d9f9d ("spi: add driver for NXP XSPI controller")

Commit message has a typo: "perations" should be "operations". Please
fix before sending.

Overall the change is sound. Moving initialization to probe and using
reinit_completion() in the hot path is the recommended pattern.

AI bot review and may be useless.