Re: [PATCH] futex: add missing function parameter comments

From: Randy Dunlap

Date: Tue Mar 03 2026 - 19:47:13 EST




On 3/3/26 6:23 AM, André Almeida wrote:

>>   include/asm-generic/futex.h |    4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> --- linux-next-20260211.orig/include/asm-generic/futex.h
>> +++ linux-next-20260211/include/asm-generic/futex.h
>> @@ -25,7 +25,9 @@
>>    *              argument and comparison of the previous
>>    *              futex value with another constant.
>>    *
>> - * @encoded_op:    encoded operation to execute
>> + * @op:        encoded operation to execute
>
> I think we don't need the "encoded" part anymore
>
>> + * @oparg:    operation code (one of FUTEX_OP_...)
>
> This is the argument of the operation, e.g when op is FUTEX_OP_ADD, oparg is the value to be added.
>
>> + * @oval:    previous value at @uaddr on successful return
>>    * @uaddr:    pointer to user space address
>>    *
>>    * Return:
>

Thanks. I'll send a v2.

--
~Randy