Re: [PATCH RFT v3 1/2] arm64: dts: qcom: glymur: Describe display related nodes

[Dmitry Baryshkov]

On Wed, Mar 04, 2026 at 05:05:58AM +0200, Dmitry Baryshkov wrote:
> On Tue, Mar 03, 2026 at 12:44:08PM +0200, Abel Vesa wrote:
> > From: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > 
> > The MDSS (Mobile Display SubSystem) on Glymur comes with 4 DisplayPort
> > controllers. Describe them along with display controller and the eDP
> > PHY. Then, attach the combo PHYs link and vco_div clocks to the Display
> > clock controller and link up the PHYs and DP endpoints in the graph.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/glymur.dtsi | 471 ++++++++++++++++++++++++++++++++++-
> >  1 file changed, 463 insertions(+), 8 deletions(-)
> > 
> > +				mdss_dp0_opp_table: opp-table {
> > +					compatible = "operating-points-v2";
> > +
> > +					opp-192000000 {
> 
> This should be 160000000, otherwise RBR mode will select the wrong clock
> rate.

Excuse me, it should be opp-162000000.

> 
> > +						opp-hz = /bits/ 64 <192000000>;
> > +						required-opps = <&rpmhpd_opp_low_svs_d1>;
> > +					};
> > +

-- 
With best wishes
Dmitry