[PATCH] usb: core: remove unnecessary goto in usb_create_newid_files()
From: Mark Adamenko
Date: Tue Mar 03 2026 - 22:36:31 EST
The goto to 'exit' only returns the already initialized variable
'error', which would be 0. At that point it could not yet be anything
else. Replacing with an early return 0 removes the
need for the label entirely.
Signed-off-by: Mark Adamenko <marusik.adamenko@xxxxxxxxx>
---
drivers/usb/core/driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 2574e65bc640..571b7d78e814 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -186,7 +186,7 @@ static int usb_create_newid_files(struct usb_driver *usb_drv)
int error = 0;
if (usb_drv->no_dynamic_id)
- goto exit;
+ return error;
if (usb_drv->probe != NULL) {
error = driver_create_file(&usb_drv->driver,
@@ -199,8 +199,6 @@ static int usb_create_newid_files(struct usb_driver *usb_drv)
&driver_attr_new_id);
}
}
-exit:
- return error;
}
static void usb_remove_newid_files(struct usb_driver *usb_drv)
--
2.53.0