Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Neeraj Soni]

On 3/2/2026 10:08 PM, Krzysztof Kozlowski wrote:
> On 02/03/2026 12:25, Neeraj Soni wrote:
>>
>>
>> On 3/2/2026 2:27 PM, Krzysztof Kozlowski wrote:
>>> On 02/03/2026 08:48, Krzysztof Kozlowski wrote:
>>>> On 02/03/2026 08:45, Neeraj Soni wrote:
>>>>>
>>>>>
>>>>> On 2/19/2026 1:57 PM, Krzysztof Kozlowski wrote:
>>>>>> On 19/02/2026 06:38, Neeraj Soni wrote:
>>>>>>>>>  
>>>>>>>>> +  - if:
>>>>>>>>> +      required:
>>>>>>>>> +        - qcom,ice
>>>>>>>>> +    then:
>>>>>>>>> +      properties:
>>>>>>>>> +        reg-names:
>>>>>>>>> +          not:
>>>>>>>>> +            contains:
>>>>>>>>> +              const: ice
>>>>>>>>
>>>>>>>> And reg is still 4? This is not correct syntax. You need to define
>>>>>>>> proper and final constraints per each device. I would write example, but
>>>>>>>> why... more things you could just ignore.
>>>>>>>>
>>>>>>> I had included changes for reg in v3:
>>>>>>> https://lore.kernel.org/all/20260206112053.3287756-2-neeraj.soni@xxxxxxxxxxxxxxxx/
>>>>>>>
>>>>>>> but those were not reviewed so i assume them to be incorrect and dropped it.
>>>>>>> Will fix this in next patch and post.
>>>>>>>
>>>>>> Patch v3 was also not correct, because SDHCI v5 devices should have 1 or
>>>>>> 2 entries, not 1-3 as previous patch said.
>>>>>>
>>>>> This is not clear to me. Here:
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n80
>>>>> it says the entries should be 1-4 and there are no v5 specific constraints.
>>>>
>>>> There are, just scroll.
>>>
>>> Here:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n212
>>>
>> Yes i had looked at this but, as i understand, this constraints the minItems: not the
>> maxItems: and in your comment here:
>>
>> https://lore.kernel.org/all/21a87714-cd11-4217-a2aa-82fddc3a8530@xxxxxxxxxx/
>>
>> you expect v5 entries to be constrained to 1-2 and not 1-3. So, as i understand from here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n78
>>
>> the v5 can have 1-4 entries without "qcom,ice" and 1-3 with it which is what i had posted.
> 
> We have long discussion and you are just not replying to the problem. I
> am done here. I wrote already what is wrong and what I expect.
> 
> Repeating the same as before in the FIRST comment: Your patch allows
> incorrectly four reg entries for v4 and there reg entries for v5.
> 
Sure. I will test and post the new patch with constraints for v4 and v5.

> That's a NAK.
> 
> Best regards,
> Krzysztof
> 
Regards,
Neeraj