Re: [PATCH net-next 0/5] ethtool: Dynamic RSS context indirection table resizing

[Pavan Chebbi]

>
> Open items:
>
>  - Pre-existing bug in bnxt: the IFF_RXFH_CONFIGURED guard in
>    bnxt_set_channels() only protects context 0. If context 0 uses
>    defaults but non-default contexts exist, channel changes that
>    change the table size succeed without updating ctx->indir_size for
>    those contexts. The core's ethtool_check_max_channel() prevents
>    invalid queue references but not the size mismatch itself. This
>    series fixes it by resizing all contexts. Should a separate fix be
>    sent to net for the existing bug?

You are right. Our re-size requirement check should include checking
of presence of any additional contexts and fail the channel change.
So the net effect is that ring 0 would get included/overburdened for
the additional contexts and that's an issue for sure though its not
catastrophic.
So IMO we could have a fix for net..

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature