Re: [PATCH v2 12/14] reset: convert the core API to using firmware nodes

[Philipp Zabel]

On Mo, 2026-02-23 at 11:06 +0100, Bartosz Golaszewski wrote:
> In order to simplify the commit converting the internals of reset core
> to using firmware nodes, first convert the user-facing API. Modify the
> signature of the core consumer functions but leave the specialized
> wrappers as is to avoid modifying users for now.
> 
> No functional change intended.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
>  drivers/reset/core.c  | 33 ++++++++++++++++++---------------
>  include/linux/reset.h | 43 ++++++++++++++++++++++++++++---------------
>  2 files changed, 46 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index b215f5a4aab3f7b625b35d183068633c9c581067..1ac68371b77101b18db5a16c6471cfffee0dce7c 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
[...]
> @@ -1454,23 +1456,24 @@ static int fwnode_reset_control_get_count(struct fwnode_handle *fwnode)
>  }
>  
>  /**
> - * of_reset_control_array_get - Get a list of reset controls using
> - *				device node.
> + * fwnode_reset_control_array_get - Get a list of reset controls using
> + *                                  a firmware node.
>   *
> - * @np: device node for the device that requests the reset controls array
> + * @fwnode: firmware node for the device that requests the reset controls array
>   * @flags: whether reset controls are shared, optional, acquired
>   *
>   * Returns pointer to allocated reset_control on success or error on failure
>   */
>  struct reset_control *
> -of_reset_control_array_get(struct device_node *np, enum reset_control_flags flags)

Please also drop of_reset_control_array_get from Documentation/driver-
api/reset.rst.

> +fwnode_reset_control_array_get(struct fwnode_handle *fwnode,
> +			       enum reset_control_flags flags)
>  {
[...]

Otherwise,
Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

regards
Philipp