Re: [PATCH v2 1/2] rust: pin-init: internal: init: remove `#[disable_initialized_field_access]`

From: Miguel Ojeda

Date: Wed Mar 04 2026 - 07:30:16 EST


On Wed, Mar 4, 2026 at 8:00 AM Benno Lossin <lossin@xxxxxxxxxx> wrote:
>
> I figured that we can't really "close" a Zulip topic (we can mark it as
> completed, but that topic was originally about the field accessors, so
> not sure if this makes much sense.

Using Link: instead of Closes: is supposed to mean that only part of
the issue is fixed, i.e. whether you can "technically close" it or not
is not important (e.g. Closes: to an archive like lore.kernel.org are
very common and actually what the docs mention as the first use case).

So I would say Closes: should be the "default", and Link: is for
particular cases where an actual issue (or message) carries several
topics and could be confusing to have several commits with the exact
same Closes: line.

In the case of Zulip, we can link to particular messages in a single
thread, so typically it is possible to use Closes:, though the current
UI isn't great to see where exactly it was linked to... :(

Anyway, I guess the inspiration was the similar feature from forges,
and perhaps in case someone has a custom tracking system that actually
auto-closes things in a forge, but it is a bit confusing. Having
allowed "# ..." for Closes: or a similar Closes(foo): instead of
reusing Link: may have been better.

I hope that helps!

Cheers,
Miguel