Re: [PATCH net 3/3] amd-xgbe: reset PHY settings before starting PHY

From: Maxime Chevallier

Date: Wed Mar 04 2026 - 08:45:04 EST


Hi Raju,

On 04/03/2026 13:23, Raju Rangoju wrote:
> commit f93505f35745 ("amd-xgbe: let the MAC manage PHY PM") moved
> xgbe_phy_reset() from xgbe_open() to xgbe_start(), placing it after
> phy_start(). As a result, the PHY settings were being reset after the
> PHY had already started.
>
> Reorder the calls so that the PHY settings are reset before
> phy_start() is invoked.
>
> Fixes: f93505f35745 ("amd-xgbe: let the MAC manage PHY PM")
> Signed-off-by: Raju Rangoju <Raju.Rangoju@xxxxxxx>

This looks good to me,

Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Maxime