Re: 回复：[PATCH v5 net-next 11/11] net/nebula-matrix: add common dev start/stop operation

[Andrew Lunn]

On Wed, Mar 04, 2026 at 03:20:44PM +0800, Illusion Wang wrote:
> 
> > > +int nbl_dev_start(struct nbl_adapter *adapter, struct nbl_init_param *param)
> > > +{
> > > + int ret;
> > > +
> > > + ret = nbl_dev_start_common_dev(adapter, param);
> > > + return ret;
> 
> >return nbl_dev_start_common_dev(adapter, param);
> 
> >But then i have to ask, why bother having nbl_dev_start() when you can
> >just call nbl_dev_start_common().
> 
> You're absolutely right. However, we're considering facilitating future
> expansion for the next-stage netdev configuration.

You seem to be over engineering this whole driver. It seems a lot more
complex than it needs to be. Complex drivers take a lot longer to get
merged, some never get merged. Drivers which start KISS, and slowly
get features added get merged a lot faster.

    Andrew