Re: [PATCH v4 0/4] x86/tdx: Clean up the definitions of TDX TD ATTRIBUTES

From: Nikolay Borisov

Date: Wed Mar 04 2026 - 10:11:43 EST




On 3.03.26 г. 5:03 ч., Xiaoyao Li wrote:
The main purpose of this series was to remove redundant macros between
core TDX and KVM, along with a typo fix. They were implemented as patch 1
and patch 2.

During the review of v1 and v2, there was encouragement to refine the
names of the macros related to TD attributes to clarify their scope.
Thus patch 3 and patch 4 are added.

Note, Binbin suggested to rename tdx_attributes[] to tdx_td_attributes[]
during v3 review. However, this v4 doesn't do it but leaves it for future
cleanup to avoid making it more complicated because it also looks like
it needs to rename "Attributes" to "TD Attributes" in tdx_dump_attributes(),
which has user visibility change.



Reviewed-by: Nikolay Borisov <nik.borisov@xxxxxxxx>