Re: [PATCH v2 1/7] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding
From: Krzysztof Kozlowski
Date: Wed Mar 04 2026 - 10:17:22 EST
On 03/03/2026 19:10, Vikash Garodia wrote:
>
>>
>> ...
>>
>>> + };
>>> diff --git a/include/dt-bindings/media/qcom,iris.h b/include/dt-bindings/media/qcom,iris.h
>>
>> Filename must match binding/compatible. I asked for this multiple times.
>>
>
> in this case, its applicable for other platforms as well. Naming it as
> qcom,kaanapali-iris.h would make it look like kaanapali specific.
I repeated that feedback way too many times.
NAK
Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx
Best regards,
Krzysztof