Re: [PATCH v2 08/11] scsi: ufs: ufs-qcom: Implement vops tx_eqtr_notify()

[Manivannan Sadhasivam]

On Wed, Mar 04, 2026 at 05:53:10AM -0800, Can Guo wrote:
> On some platforms, HW does not support triggering TX EQTR from the most
> reliable High-Speed (HS) Gear (HS Gear1), but only allows to trigger TX
> EQTR for the target HS Gear from the same HS Gear. To work around the HW
> limitation, implement vops tx_eqtr_notify() to change Power Mode to the
> target TX EQTR HS Gear prior to TX EQTR procedure and change Power Mode
> back to HS Gear1 (the most reliable gear) post TX EQTR procedure.
> 
> Signed-off-by: Can Guo <can.guo@xxxxxxxxxxxxxxxx>
> ---
>  drivers/ufs/host/ufs-qcom.c | 63 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 3a9279066192..1e074058f23d 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -2512,6 +2512,68 @@ static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
>  	return min_t(u32, gear, hba->max_pwr_info.info.gear_rx);
>  }
>  
> +static int ufs_qcom_change_power_mode(struct ufs_hba *hba,
> +				      struct ufs_pa_layer_attr *pwr_mode,
> +				      enum ufshcd_pmc_policy pmc_policy)
> +{
> +	int ret;
> +
> +	ret = ufs_qcom_pwr_change_notify(hba, PRE_CHANGE, pwr_mode);
> +	if (ret) {
> +		dev_err(hba->dev, "Power change notify (PRE_CHANGE) failed: %d\n",
> +			ret);
> +		return ret;
> +	}
> +
> +	ret = ufshcd_change_power_mode(hba, pwr_mode, pmc_policy);
> +	if (ret)
> +		return ret;
> +
> +	ufs_qcom_pwr_change_notify(hba, POST_CHANGE, pwr_mode);
> +
> +	return ret;

return 0;

> +}
> +
> +static int ufs_qcom_tx_eqtr_notify(struct ufs_hba *hba,
> +				   enum ufs_notify_change_status status,
> +				   struct ufs_pa_layer_attr *pwr_mode)
> +{
> +	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> +	struct ufs_pa_layer_attr pwr_mode_hs_g1 = {
> +		.gear_rx = UFS_HS_G1,
> +		.gear_tx = UFS_HS_G1,
> +		.lane_rx = pwr_mode->lane_rx,
> +		.lane_tx = pwr_mode->lane_tx,
> +		.pwr_rx = FAST_MODE,
> +		.pwr_tx = FAST_MODE,
> +		.hs_rate = pwr_mode->hs_rate,
> +	};
> +	u32 gear = pwr_mode->gear_tx;
> +	u32 rate = pwr_mode->hs_rate;
> +	int ret;
> +
> +	if (host->hw_ver.major != 0x7 || host->hw_ver.minor > 0x1)
> +		return 0;
> +
> +	if (status == PRE_CHANGE) {
> +		/* PMC to target HS Gear. */
> +		ret = ufs_qcom_change_power_mode(hba, pwr_mode,
> +						 UFSHCD_PMC_POLICY_DONT_FORCE);
> +		if (ret)
> +			dev_err(hba->dev, "%s: Failed to change power mode to target HS-G%u, Rate-%s: %d\n",

Same comment as other patch. Goes over 100 column.

> +				__func__, gear, UFS_HS_RATE_STRING(rate), ret);

Can we please not specify the function name in error log?

- Mani

-- 
மணிவண்ணன் சதாசிவம்