Re: [PATCH net-next 2/8] dt-bindings: net: lan9645x: add LAN9645X switch bindings

[Jens Emil Schulz Ostergaard]

On Tue, 2026-03-03 at 15:18 +0100, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> > +        properties:
> > +          microchip,led-drive-mode:
> > +            $ref: /schemas/types.yaml#/definitions/uint32
> > +            description: |
> > +              Set the LED drive mode for the copper PHY associated with
> > +              this port.
> > +
> > +                0 - LED1 and LED2 in open-drain mode
> > +                1 - LED1 in active drive mode (can be used for single-LED
> > +                    configurations requiring active drive)
> > +                2 - Reserved
> > +                3 - LED1 and LED2 in active drive mode
> > +            minimum: 0
> > +            maximum: 3
> 
> I doubt the DT Maintainers will accept that. This looks a lot like a
> value you write into a register. How are active drive and open-drain
> described in other DT bindings? Is there something you can reuse?
> 
> For 1, what happens to LED2? Not used at all?
> 
>     Andrew

Yes, this is written to a register. I did not know that was a no-no.
I believe LED2 is not used, but I will ask design about 1 and LED2 to
be sure. The register model does not mention LED2 here.

Thanks,
Emil