Re: [PATCH 1/2] dt-bindings: crypto: eip93: add clock gate and reset line

[Aleksander Jan Bajkowski]

Hi Conor,

On 3/4/26 20:08, Conor Dooley wrote:
> On Tue, Mar 03, 2026 at 08:39:17PM +0100, Aleksander Jan Bajkowski wrote:
> > Add the clock gate and reset line, both of which are available
> > on the Airoha AN7581. Both properties are optional.
> Why are they optional?

No reason. In theory, a hardware designer could connect the reset
to a fixed input signal. In practice, all SoCs on the market have
a built-in reset and clock controller. I can mark them as required
in the next revision.

> > Signed-off-by: Aleksander Jan Bajkowski <olek2@xxxxx>
> > ---
> >   .../crypto/inside-secure,safexcel-eip93.yaml         | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
> > index 997bf9717f9e..058454b679b4 100644
> > --- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
> > @@ -48,6 +48,12 @@ properties:
> >     interrupts:
> >       maxItems: 1
> >   
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> >   required:
> >     - compatible
> >     - reg
> > @@ -57,11 +63,17 @@ additionalProperties: false
> >   
> >   examples:
> >     - |
> > +    #include <dt-bindings/clock/en7523-clk.h>
> >       #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/reset/airoha,en7581-reset.h>
> >   
> >       crypto@1e004000 {
> >         compatible = "airoha,en7581-eip93", "inside-secure,safexcel-eip93ies";
> >         reg = <0x1fb70000 0x1000>;
> >   
> > +      clocks = <&scuclk EN7523_CLK_CRYPTO>;
> > +
> >         interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > +      resets = <&scuclk EN7581_CRYPTO_RST>;
> >       };
> > --
> > 2.47.3
Best regards,
Aleksander