Re: [PATCH net] net: bcmgenet: fix bcmgenet_get_eee() clobbered by phy_ethtool_get_eee()

[Andrew Lunn]

On Tue, Mar 03, 2026 at 04:39:18PM +0100, Nicolai Buchwitz wrote:
> bcmgenet_get_eee() sets the MAC-managed tx_lpi_enabled and tx_lpi_timer
> fields, then calls phy_ethtool_get_eee() which internally calls
> eeecfg_to_eee() — overwriting eee_enabled, tx_lpi_enabled and
> tx_lpi_timer with the PHY's eee_cfg values.  For non-phylink MACs like
> GENET, these PHY-level fields are never initialized (they are only set
> by phylink via phy_support_eee()), so the ethtool report always shows
> eee_enabled=false and tx_lpi_enabled=false regardless of the actual MAC
> state.

I think the MAC driver is missing a call to phy_support_eee() to let
phylib know the MAC supports EEE. Have you tried that.

       Andrew