Re: [PATCH v2 1/2] dt-bindings: iio: temperature: add ADI MAX30210

From: David Lechner

Date: Wed Mar 04 2026 - 19:11:33 EST


On 3/4/26 6:25 AM, John Erasmus Mari Geronimo wrote:
> Add device tree binding documentation for the Analog Devices
> MAX30210 temperature sensor.
>
> Signed-off-by: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@xxxxxxxxxx>
> ---
> .../iio/temperature/adi,max30210.yaml | 62 +++++++++++++++++++
> MAINTAINERS | 7 +++
> 2 files changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/temperature/adi,max30210.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,max30210.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,max30210.yaml
> new file mode 100644
> index 000000000000..66867880a20f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/adi,max30210.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2026 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/temperature/adi,max30210.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX30210 Temperature Sensor
> +
> +maintainers:
> + - John Erasmus Mari Geronimo <johnerasmusmari.geronimo@xxxxxxxxxx>
> +
> +description: |
> + The MAX30210 is a temperature sensor with an I2C interface.
> + https://www.analog.com/media/en/technical-documentation/data-sheets/max30210.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,max30210
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: Analog supply voltage input.

The description makes it sound like there could be other supplies,
but there aren't. It is the "everything" supply, so we can just
call it the power supply.

> +
> + powerdown-gpios:
> + description: GPIO connected to the CVT/PDB pin (active low).
> + maxItems: 1
> +
> + interrupts:
> + description: Connected to INT pin. Interrupt triggered on both rising and falling edges.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + temperature-sensor@40 {
> + compatible = "adi,max30210";
> + reg = <0x40>;
> + vdd-supply = <&vdd>;
> + powerdown-gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
> +
> + interrupt-parent = <&gpio>;
> + interrupts = <17 IRQ_TYPE_EDGE_BOTH>;
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1c75276404df..09345b9f32ed 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1638,6 +1638,13 @@ W: https://ez.analog.com/linux-software-drivers
> F: Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml
> F: drivers/iio/dac/max22007.c

It looks like MAX22007 is not in alphabetical order. Let's fix it
first so we can put this new one in the right place.

>
> +ANALOG DEVICES INC MAX30210 DRIVER
> +M: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@xxxxxxxxxx>
> +L: linux-iio@xxxxxxxxxxxxxxx
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/iio/temperature/adi,max30210.yaml
> +
> ANALOG DEVICES INC ADA4250 DRIVER
> M: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> L: linux-iio@xxxxxxxxxxxxxxx