Re: [PATCH net] net: ncsi: fix skb leak in error paths

From: Jakub Kicinski

Date: Wed Mar 04 2026 - 19:46:05 EST


On Mon, 2 Mar 2026 13:46:29 +0800 Jian Zhang wrote:
> +bail:

please give meaningful names to the labels, eg:

err_free_skb:

> + consume_skb(skb);

since this is a drop condition kfree_skb() seems more appropriate.

> + return ret;
--
pw-bot: cr