Re: [PATCH v10 bpf-next 2/2] selftests/bpf: Add selftests for the invocation of bpf_lwt_xmit_push_encap

[Martin KaFai Lau]

On 3/4/26 2:33 AM, Leon Hwang wrote:
> On 4/3/26 17:44, Feng Yang wrote:
> > From: Feng Yang <yangfeng@xxxxxxxxxx>
> >
> > Calling bpf_lwt_xmit_push_encap will not cause a crash when dst is missing.
> >
> > Signed-off-by: Feng Yang <yangfeng@xxxxxxxxxx>
> > ---
> >   .../selftests/bpf/prog_tests/lwt_misc.c       |  9 ++++++++
> >   tools/testing/selftests/bpf/progs/lwt_misc.c  | 22 +++++++++++++++++++
> >   2 files changed, 31 insertions(+)
> >   create mode 100644 tools/testing/selftests/bpf/prog_tests/lwt_misc.c
> >   create mode 100644 tools/testing/selftests/bpf/progs/lwt_misc.c
>
> Unnecessary to create new files.
>
> Move the adding test to verifier_lwt.c. prog_tests/verifier.c will run
> the test.

It is actually the change from v9 to v10. I think leaving it separate is 
better. It is not testing the verifier, so logically it does not fit in 
verifier_lwt.c. It probably won't be the last fix for test_run+lwt, so 
separating it should be useful going forward.