Re: [PATCH net-next v5 1/2] net/sched: cls_flower: remove unions from fl_flow_key

[Jakub Kicinski]

On Tue, 03 Mar 2026 14:18:23 +0100 Cedric Jehasse via B4 Relay wrote:
> When creating a flower classifier with an ipv4 address the
> flow_dissector has both FLOW_DISSECTOR_KEY_IPV4_ADDRS and
> FLOW_DISSECTOR_KEY_IPV6_ADDRS bits set in used_keys.
> This happens because ipv4/ipv6 fields are a union and
> FL_KEY_SET_IF_MASKED() will interpret either being set as both.
> 
> Removing the unions fixes this behavior without needing special handling
> for union fields.

Jiri, this change is fine right?