Re: [PATCH v2 2/7] dt-bindings: clock: qcom: Add X1P42100 camera clock controller

[Krzysztof Kozlowski]

On Wed, Mar 04, 2026 at 11:10:52PM +0530, Jagadeesh Kona wrote:
> Add X1P42100 camera clock controller support and clock bindings
> for camera QDSS debug clocks which are applicable for both
> X1E80100 and X1P42100 platforms.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jagadeesh Kona <jagadeesh.kona@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml | 1 +
>  include/dt-bindings/clock/qcom,x1e80100-camcc.h                  | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml
> index 938a2f1ff3fca899b5708101df7f8aa07e943336..b28614186cc098268ab0d8c32b21d9dd9508c9f9 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml
> @@ -23,6 +23,7 @@ properties:
>    compatible:
>      enum:
>        - qcom,x1e80100-camcc
> +      - qcom,x1p42100-camcc
>  
>    reg:
>      maxItems: 1
> diff --git a/include/dt-bindings/clock/qcom,x1e80100-camcc.h b/include/dt-bindings/clock/qcom,x1e80100-camcc.h
> index d72fdfb06a7c716ed2ec376e061e4f0ca35f42c5..06c316022fb0d26ec6243b28477564d97f228c8e 100644
> --- a/include/dt-bindings/clock/qcom,x1e80100-camcc.h
> +++ b/include/dt-bindings/clock/qcom,x1e80100-camcc.h
> @@ -115,6 +115,9 @@
>  #define CAM_CC_SLEEP_CLK_SRC					105
>  #define CAM_CC_SLOW_AHB_CLK_SRC					106
>  #define CAM_CC_XO_CLK_SRC					107
> +#define CAM_CC_QDSS_DEBUG_CLK					108
> +#define CAM_CC_QDSS_DEBUG_CLK_SRC				109
> +#define CAM_CC_QDSS_DEBUG_XO_CLK				110

Why X1E now gets all these clocks? I don't understand why you are having
separate drivers and decided to change the ABI used in the first driver?

Best regards,
Krzysztof