Re: [PATCH v8 11/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft

From: Nicolas Frattaroli

Date: Thu Mar 05 2026 - 05:06:02 EST


On Thursday, 5 March 2026 10:14:47 Central European Standard Time Peter Wang (王信友) wrote:
> On Wed, 2026-03-04 at 15:53 +0100, Nicolas Frattaroli wrote:
> > @@ -2383,38 +2383,12 @@ MODULE_DEVICE_TABLE(of, ufs_mtk_of_match);
> > static int ufs_mtk_probe(struct platform_device *pdev)
> > {
> > int err;
> > - struct device *dev = &pdev->dev, *phy_dev = NULL;
> >
>
> Will there be a build error if phy_dev is removed?
> Please make sure that each patch can build successfully, one by one.
>
> Thanks
> Peter
>
>
>
>

Yes, these are the kinds of mistakes that happen when you ask someone
to pick apart patches for your downstream convenience.

I'll hand dealing with any further fixups and variable naming concerns
you have over to Angelo, as I can't be bothered to deal with you
anymore.