Re: [PATCH v3 2/2] media: i2c: mt9m114: add support for Aptina MI1040

[Svyatoslav Ryhel]

чт, 5 бер. 2026 р. о 12:00 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> пише:
>
> Hi Svyatoslav,
>
> On Thu, Mar 05, 2026 at 10:36:25AM +0200, Svyatoslav Ryhel wrote:
> > ср, 4 бер. 2026 р. о 23:43 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> пише:
> > >
> > > Hi Svyatoslav,
> > >
> > > One more thing...
> > >
> > > On Wed, Mar 04, 2026 at 08:50:01PM +0200, Svyatoslav Ryhel wrote:
> > > > @@ -2646,9 +2658,18 @@ static void mt9m114_remove(struct i2c_client *client)
> > > >       pm_runtime_set_suspended(dev);
> > > >  }
> > > >
> > > > +static const struct mt9m114_model_info mt9m114_models_default = {
> > > > +     .state_standby_polling = true,
> > > > +};
> > > > +
> > > > +static const struct mt9m114_model_info mt9m114_models_aptina = {
> > > > +     .state_standby_polling = false,
> > > > +};
> > > > +
> > > >  static const struct of_device_id mt9m114_of_ids[] = {
> > > > -     { .compatible = "onnn,mt9m114" },
> > > > -     { /* sentinel */ },
> > > > +     { .compatible = "onnn,mt9m114", .data = &mt9m114_models_default },
> > > > +     { .compatible = "aptina,mi1040", .data = &mt9m114_models_aptina },
> > > > +     { /* sentinel */ }
> > >
> > > The driver also supports ACPI. mt9m114_models_default needs to be added to
> > > the ACPI data, too; otherwise ACPI support breaks.
> > >
> >
> > So turn into
> >
> > static const struct acpi_device_id mt9m114_acpi_ids[] = {
> >     { "INT33F0" },
> >     { /* sentinel */ },
> > };
> >
> > into
> >
> > static const struct acpi_device_id mt9m114_acpi_ids[] = {
> >     { "INT33F0", (kernel_ulong_t)&mt9m114_models_default },
> >     { /* sentinel */ }
> > };
>
> Looks good to me.
>
> >
> > I want to be as specific as possible to avoid any misunderstandings.
> > Additionally, please ensure these are all the required changes to
> > avoid unwanted reiterations, as I may not be as familiar with the
> > media framework as you are. Thank you!
>
> That's what I noticed after going through this once more.
>
> Review won't make patches perfect (mostly) but the more issues can be found
> during review, the better.
>

Yes, but the more iterations pass, more issues may occur due to
mechanical typos or unintentional misbehaviors.

> >
> > > >  };
> > > >  MODULE_DEVICE_TABLE(of, mt9m114_of_ids);
> > > >
> > >
>
> --
> Kind regards,
>
> Sakari Ailus