Re: [1/2] octeontx2-af: siplify rvu_debugfs

[Simon Horman]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
octeontx2-af: siplify rvu_debugfs

The driver uses bitmap_print_to_pagebuf() to store human-readable
bitmaps representations in a temporary buffers; and then feed
seq_printf() with it. Switch to using seq_printf("%*pb") directly
and drop intermediate buffer.

> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
> index 413f9fa40b33..cae61c4de47f 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
> @@ -962,30 +962,21 @@ static bool rvu_dbg_is_valid_lf(struct rvu *rvu, int blkaddr, int lf,
>
>  static void print_npa_qsize(struct seq_file *m, struct rvu_pfvf *pfvf)
>  {
> -	char *buf;
> -
> -	buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
> -	if (!buf)
> -		return;
> -
>  	if (!pfvf->aura_ctx) {
>  		seq_puts(m, "Aura context is not initialized\n");
>  	} else {
> -		bitmap_print_to_pagebuf(false, buf, pfvf->aura_bmap,
> -					pfvf->aura_ctx->qsize);
>  		seq_printf(m, "Aura count : %d\n", pfvf->aura_ctx->qsize);
> -		seq_printf(m, "Aura context ena/dis bitmap : %s\n", buf);
> +		seq_printf(m, "Aura context ena/dis bitmap : %*pb\n",
> +			   pfvf->aura_ctx->qsize, pfvf->aura_bmap);
>  	}
>
>  	if (!pfvf->pool_ctx) {
>  		seq_puts(m, "Pool context is not initialized\n");
>  	} else {
> -		bitmap_print_to_pagebuf(false, buf, pfvf->pool_bmap,
> -					pfvf->pool_ctx->qsize);
>  		seq_printf(m, "Pool count : %d\n", pfvf->pool_ctx->qsize);
> -		seq_printf(m, "Pool context ena/dis bitmap : %s\n", buf);
> +		seq_printf(m, "Pool context ena/dis bitmap : %*pb\n",
> +			   pfvf->aura_ctx->qsize, pfvf->aura_bmap);
                   ^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^

Does this code have a copy-paste error? The pool context output is
displaying the aura bitmap instead of the pool bitmap.

The old code correctly used pfvf->pool_bmap and pfvf->pool_ctx->qsize:

    bitmap_print_to_pagebuf(false, buf, pfvf->pool_bmap,
                            pfvf->pool_ctx->qsize);

But the new code uses pfvf->aura_bmap and pfvf->aura_ctx->qsize for
both the aura and pool context displays. This makes the pool context
debugfs output show incorrect information.

>  	}
> -	kfree(buf);
>  }

[ ... ]