Re: [net-next,v3,3/8] bng_en: add ethtool link settings, get_link, and nway_reset

From: Bhargava Chenna Marreddy

Date: Thu Mar 05 2026 - 05:58:11 EST


On Wed, Mar 4, 2026 at 11:47 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 4 Mar 2026 16:07:09 +0530 Bhargava Chenna Marreddy wrote:
> > The code was functionally safe, but I agree the inconsistency in the
> > array patterns was not ideal.
>
> Well TBH I think AI is being generous in how it phrases it's feedback.
> Assuming an arbitrary value in an enum is and always will be the last
> one is asking for bugs.

Point taken. I’ll switch to explicit sizing to avoid the enum fragility.

Thanks,
Bhargava

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature