Re: [PATCH v3 3/8] module: Give 'enum pkey_id_type' a more specific name

[=?utf-8?q?Thomas_Wei=C3=9Fschuh?=]

On Thu, Mar 05, 2026 at 10:52:47AM +0000, David Howells wrote:
> 
> Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx> wrote:
> 
> > -enum pkey_id_type {
> > -	PKEY_ID_PKCS7 = 2,	/* Signature in PKCS#7 message */
> > +enum module_signature_type {
> > +	MODULE_SIGNATURE_TYPE_PKCS7 = 2,	/* Signature in PKCS#7 message */
> >  };
> 
> It might be best to just kill the enum and replace it with a single #define.

I am about to introduce another value in [0].
But personally I don't really care one way or another.

[0] https://lore.kernel.org/lkml/20260113-module-hashes-v4-0-0b932db9b56b@xxxxxxxxxxxxxx/