Re: [PATCH net-next] net: dsa: realtek: rtl8365mb: remove ifOutDiscards from rx_packets

[Linus Walleij]

On Tue, Mar 3, 2026 at 9:25 PM Luiz Angelo Daros de Luca
<luizluca@xxxxxxxxx> wrote:

> From: Mieczyslaw Nalewaj <namiltd@xxxxxxxxx>
>
> rx_packets should report the number of frames successfully received:
> unicast + multicast + broadcast. Subtracting ifOutDiscards (a TX
> counter) is incorrect and can undercount RX packets. RX drops are
> already reported via rx_dropped (e.g. etherStatsDropEvents), so
> there is no need to adjust rx_packets.
>
> This patch removes the subtraction of ifOutDiscards from rx_packets
> in rtl8365mb_stats_update().
>
> Link: https://lore.kernel.org/netdev/878777925.105015.1763423928520@xxxxxxxxxxxxxx/
> Fixes: 4af2950c50c8 ("net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC")
> Signed-off-by: Mieczyslaw Nalewaj <namiltd@xxxxxxxxx>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>

Acked-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij