Re: [PATCH 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support

[Krzysztof Kozlowski]

On 05/03/2026 06:47, Hongyang Zhao wrote:
>  
>  &apps_rsc {
> @@ -727,6 +755,23 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcs6490/a660_zap.mbn";
>  };
>  
> +&i2c0 {
> +	status = "okay";
> +
> +	es8316: es8316@11 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> +		compatible = "everest,es8316";
> +		reg = <0x11>;
> +		#sound-dai-cells = <0>;
> +
> +		clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +		clock-names = "mclk";
> +
> +		interrupts-extended = <&tlmm 63 IRQ_TYPE_EDGE_BOTH>;
> +
> +		everest,jack-detect-inverted;
> +	};



Best regards,
Krzysztof