Re: [PATCH phy-next 18/22] pinctrl: tegra-xusb: include PHY provider header
From: Linus Walleij
Date: Thu Mar 05 2026 - 07:50:49 EST
On Thu, Mar 5, 2026 at 1:43 PM Linus Walleij <linusw@xxxxxxxxxx> wrote:
> On Wed, Mar 4, 2026 at 7:00 PM Vladimir Oltean <vladimir.oltean@xxxxxxx> wrote:
>
> > The tegra-xusb pinctrl driver is also a PHY provider (calls
> > devm_phy_create() for PCIe and SATA). However, according to Vinod Koul,
> > having PHY provider drivers outside of drivers/phy/ is discouraged,
> > although it would be difficult for me to address a proper movement here.
> >
> > Include the private provider API header from drivers/phy/, but leave a
> > FIXME in place. It will have to be moved, eventually.
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
>
> Fair enough, is this a regression so I should merge it for fixes
> or just a nonurgent fix that I can apply for next?
Sorry I realized it needs to go in with the series.
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
You can take it from here.
Yours,
Linus Walleij