Re: [PATCH v2 01/11] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode()

[Krzysztof Kozlowski]

On 04/03/2026 14:53, Can Guo wrote:
>  {
>  	int ret;
>  
> @@ -4747,6 +4745,22 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba,
>  	return ret;
>  }
>  

Missing kerneldoc.

> +int ufshcd_change_power_mode(struct ufs_hba *hba,
> +			     struct ufs_pa_layer_attr *pwr_mode)
> +{
> +	int ret;
> +
> +	ufshcd_vops_pwr_change_notify(hba, PRE_CHANGE, pwr_mode);
> +
> +	ret = ufshcd_dme_change_power_mode(hba, pwr_mode);
> +
> +	if (!ret)
> +		ufshcd_vops_pwr_change_notify(hba, POST_CHANGE, pwr_mode);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(ufshcd_change_power_mode);
> +


Best regards,
Krzysztof