Re: [PATCH net-next 1/8] net: dsa: add tag driver for LAN9645X

[Jens Emil Schulz Ostergaard]

On Wed, 2026-03-04 at 16:14 +0100, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> > > These functions are big enough i would place them into the .c file.
> > > Then, normally, i would say, please don't use inline in a C file. But
> > > here we are in the fast path. Have you tried this with and without the
> > > inline? How does it change the object size and performance?
> > > 
> > 
> > I did test performance back when I first implemented this. I had some issues
> > getting gcc to inline the functions, and that hurt performance quite a bit.
> > But I did not look at object size though. I moved them to the header so I could
> > add the inline. I can move them to the .c file in the next version.
> 
> Developers often get inline wrong:
> 
> It is used on the slow path, so all it achieves is bloating the object
> size.
> 
> It is used on tiny functions, which the compiler is likely to inline
> anyway.
> 
> Your use case is different. This is fast path, and it is not a small
> function. You also have a good justification, you know not using
> inline really does hurt performance.
> 
> So, please move this into the .c file, and use inline. And add a
> comment to the commit message adding your justification for inline.
> If something is justified, we will accept it.
> 
>         Andrew

I will do this in the next version.

Thanks,
Emil