Re: [PATCH v2] iio: adc: ti-ads1018: fix type overflow for data rate

[Kurt Borja]

On Thu Mar 5, 2026 at 9:43 AM -03, Chunyang Chen wrote:
> The variable 'drate' is currently defined as u8. However, the data rate
> values in ads1018 can reach up to 3300 Hz, which exceeds the maximum
> value of 255 that a u8 can hold.
>
> Change the type of 'drate' to u32 to match the data_rate_mode_to_hz
> array definition and ensure the data rate is handled correctly.
>
> Fixes: bf0bba486b5b ("iio: adc: ti-ads1018: add ti-ads1018 driver")
> Signed-off-by: Chunyang Chen <chenchunyang0908@xxxxxxxxx>

Reviewed-by: Kurt Borja <kuurtb@xxxxxxxxx>

>
> ---
> v2:
> - Change drate type to u32 as suggested by Kurt.
> - Add Fixes tag as requested by Andy.
> ---
>  drivers/iio/adc/ti-ads1018.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-ads1018.c b/drivers/iio/adc/ti-ads1018.c
> index 6246b3cab..0780abd0d 100644
> --- a/drivers/iio/adc/ti-ads1018.c
> +++ b/drivers/iio/adc/ti-ads1018.c
> @@ -249,7 +249,7 @@ static int ads1018_single_shot(struct ads1018 *ads1018,
>  			       struct iio_chan_spec const *chan, u16 *cnv)
>  {
>  	u8 max_drate_mode = ads1018->chip_info->num_data_rate_mode_to_hz - 1;
> -	u8 drate = ads1018->chip_info->data_rate_mode_to_hz[max_drate_mode];
> +	u32 drate = ads1018->chip_info->data_rate_mode_to_hz[max_drate_mode];
>  	u8 pga_mode = ads1018->chan_data[chan->scan_index].pga_mode;
>  	struct spi_transfer xfer[2] = {
>  		{

-- 
Thanks,
 ~ Kurt