Re: [PATCH 1/2] leds: lp5860: Fix compilation as module

[Lee Jones]

On Thu, 29 Jan 2026, Steffen Trumtrar wrote:

> When the lp5860 is compiled as module, the lp5860_device_init/remove
> functions must be exported or the spi-specific module can not use these
> functions and the compilation will fail.
> 
> Add the needed EXPORT_SYMBOL_GPL calls and while at it the
> MODULE_LICENSE and _DESCRIPTION for the lp5860-core module.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601230708.wwFMOXZp-lkp@xxxxxxxxx/
> ---
>  drivers/leds/rgb/leds-lp5860-core.c | 6 ++++++
>  drivers/leds/rgb/leds-lp5860-spi.c  | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp5860-core.c
> index 977741a070d19..28b4d86e11f1a 100644
> --- a/drivers/leds/rgb/leds-lp5860-core.c
> +++ b/drivers/leds/rgb/leds-lp5860-core.c
> @@ -185,6 +185,7 @@ int lp5860_device_init(struct device *dev)
>  
>  	return lp5860_init_dt(lp);
>  }
> +EXPORT_SYMBOL_GPL(lp5860_device_init);
>  
>  void lp5860_device_remove(struct device *dev)
>  {
> @@ -192,3 +193,8 @@ void lp5860_device_remove(struct device *dev)
>  
>  	lp5860_chip_enable_toggle(lp, LP5860_CHIP_DISABLE);
>  }
> +EXPORT_SYMBOL_GPL(lp5860_device_remove);
> +
> +MODULE_AUTHOR("Steffen Trumtrar <kernel@xxxxxxxxxxxxxx>");
> +MODULE_DESCRIPTION("TI LP5860 RGB LED core driver");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/leds/rgb/leds-lp5860-spi.c b/drivers/leds/rgb/leds-lp5860-spi.c
> index d6b8d93c09978..1a35a18f50fde 100644
> --- a/drivers/leds/rgb/leds-lp5860-spi.c
> +++ b/drivers/leds/rgb/leds-lp5860-spi.c
> @@ -85,5 +85,5 @@ static struct spi_driver lp5860_driver = {
>  module_spi_driver(lp5860_driver);
>  
>  MODULE_AUTHOR("Steffen Trumtrar <kernel@xxxxxxxxxxxxxx>");
> -MODULE_DESCRIPTION("TI LP5860 RGB LED driver");
> +MODULE_DESCRIPTION("TI LP5860 RGB LED spi driver");

Nit: "SPI"

Also, the set doesn't apply.  Please rebase.

-- 
Lee Jones [李琼斯]