Re: [PATCH v2 05/11] scsi: ufs: core: Add debugfs entries for TX Equalization params

[Bart Van Assche]

On 3/4/26 7:53 AM, Can Guo wrote:
> +static int ufs_tx_eq_params_show(struct seq_file *s, void *data)
> +{
> +	struct ufs_hba *hba = hba_from_file(s->file);
> +	struct ufshcd_tx_eq_settings *settings;
> +	struct ufshcd_tx_eq_params *params;
> +	const char *file_name = s->file->f_path.dentry->d_name.name;
> +	u32 gear = (u32)(uintptr_t)s->file->f_inode->i_private;
> +	u32 rate = hba->pwr_info.hs_rate;
> +	u32 num_lanes;
> +	int lane;

Please order declarations from longest to shortest.

> +static int ufs_tx_eqtr_record_show(struct seq_file *s, void *data)
> +{
> +	struct ufs_hba *hba = hba_from_file(s->file);
> +	struct ufshcd_tx_eq_params *params;
> +	unsigned long preshoot_bitmap, deemphasis_bitmap;
> +	unsigned int preshoot, deemphasis;
> +	const char *file_name = s->file->f_path.dentry->d_name.name;
> +	u32 (*record)[TX_HS_NUM_PRESHOOT][TX_HS_NUM_DEEMPHASIS];
> +	u32 gear = (u32)(uintptr_t)s->file->f_inode->i_private;
> +	u32 rate = hba->pwr_info.hs_rate;
> +	u32 num_lanes;
> +	int lane;
> +	char name[32];

Also here, please order declarations from longest to shortest.

> +		snprintf(name, 32, "tx_eq_hs_gear%d", gear);

Please change "32" into "sizeof(name)" as is done elsewhere in the
Linux kernel.

Thanks,

Bart.