Re: [PATCH v1 4/6] platform/chrome: chromeos_tbmc: Convert to a platform driver

[Rafael J. Wysocki]

On Thu, Mar 5, 2026 at 4:50 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
>
> On Thu, Mar 05, 2026 at 04:34:26PM +0100, Rafael J. Wysocki wrote:
> > On Thu, Mar 5, 2026 at 4:29 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Mar 04, 2026 at 07:44:26PM +0100, Rafael J. Wysocki wrote:
> > > >  static void chromeos_tbmc_notify(acpi_handle handle, u32 event, void *data)
> > > >  {
> > > > -     struct acpi_device *adev = data;
> > > > +     struct device *dev = data;
> > > > +     struct acpi_device *adev = ACPI_COMPANION(dev);
> > > >
> > > >       acpi_pm_wakeup_event(&adev->dev);
> > >                              ^^^^^^^^^^
> > > If I understand it correctly, I think this should also be changed to `dev`?
> >
> > Yes, it should.
> >
> > Essentially, this needs to be the same device for which
> > device_init_wakeup() has been called.
> >
> > Sorry for missing this.
> >
> > Do I need to resend the series with this fixes or would it be
> > sufficient to send a v2 of this particular patch?
>
> Please resend the series as v2, addressing the fix and the minor fix in
> patch [2/6].

I will, thanks!